[Gradle 8] Update to Gradle 8.13#530
Conversation
|
AGP requires Java 17, but CI is currently set to 11. I don't believe I can change anything about CI with a PR, so I am opening an issue to request a bump edit: #531 |
| kotlin { | ||
| jvmToolchain(17) | ||
| } |
There was a problem hiding this comment.
Toolchains are bad and I do not want them in use. See this. It's fine to land for now, but I will file an issue to track removal.
There was a problem hiding this comment.
Fixed with https://github.com/MrMannWood/timber/tree/toolchain
Will create a PR once the next few land
| // Update WrongTimberUsageDetectorTest#innerStringFormatWithStaticImport when >= 7.1.0-alpha07 | ||
| 'androidPlugin': '7.0.0', | ||
| 'androidPlugin': '8.10.0', | ||
| 'androidTools': '30.0.0', |
There was a problem hiding this comment.
This version should always be the previous one plus 23
| 'androidTools': '30.0.0', | |
| 'androidTools': '31.10.0', |
There was a problem hiding this comment.
Unfortunately, making this change is going to be non-trivial. It appears that the lint rules have changed and updating the android tools causes the lint test to fail. I'm investigating how to minimize the LOC of the change, but I think it's going to be reasonably large.
I would really prefer to not change tests and these dependency numbers at the same time. My preference (if I was working with HG stacks and Phabricator) would be to have this be one diff, and the next diff on the stack would be the test fixes and the tools number bump. We could then review and have CI test each revision individually, and land the stack as a single unit. If this is possible in Git I'm unaware of how to do it.
For the time being, I'll be making the tools update and the test changes in a follow up PR, and will be awaiting your feedback before fixing this one.
| 'kotlin': '2.1.20', | ||
| 'autoService': '1.1.1', | ||
|
|
||
| // Update WrongTimberUsageDetectorTest#innerStringFormatWithStaticImport when >= 7.1.0-alpha07 |
There was a problem hiding this comment.
until AGP plugin is upgraded, yes
|
You can change the JDK version in the PR. There's a |
|
re-requesting review based on discussion and not wanting an auto-merge until AGP is resolved. Also, apologies about the messy commit history, I don't use git as my primary workflow. |
|
This is what the AGP upgrade looks like. It's not horrible, but there's a lot of noise: MrMannWood@5daf3d2 |
2 participants
All changes are required to bump to Gradle 8, and cannot be applied before bumping.
@Configto work