Skip to content

Update dependency com.facebook:ktfmt to v0.62 #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeWharton merged 2 commits into from
Mar 17, 2026
+8 −8
Merged

Update dependency com.facebook:ktfmt to v0.62 #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
457dbf0
Update dependency com.facebook:ktfmt to v0.62
renovate[bot] Mar 17, 2026
8b27ff2
Reformat
JakeWharton Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ assertk = "com.willowtreeapps.assertk:assertk:0.28.1"
robolectric = "org.robolectric:robolectric:4.16.1"

spotlessPlugin = "com.diffplug.spotless:spotless-plugin-gradle:8.3.0"
ktfmt = "com.facebook:ktfmt:0.61"
ktfmt = "com.facebook:ktfmt:0.62"
14 changes: 7 additions & 7 deletions timber-lint/src/main/java/timber/lint/WrongTimberUsageDetector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,15 +520,15 @@ class WrongTimberUsageDetector : Detector(), UastScanner {
val numArguments = arguments.size

// Find the throwable and message arguments by their type, not by their position.
val throwableArgument =
arguments.firstOrNull { isSubclassOf(context, it, Throwable::class.java) }
val throwableArgument = arguments.firstOrNull {
isSubclassOf(context, it, Throwable::class.java)
}

// Find an argument that is either a String OR a literal null expression.
val messageArgument =
arguments.firstOrNull {
val type = it.getExpressionType()
(type != null && isString(type)) || (it is ULiteralExpression && it.isNull)
}
val messageArgument = arguments.firstOrNull {
val type = it.getExpressionType()
(type != null && isString(type)) || (it is ULiteralExpression && it.isNull)
}

// Handles overloads like Timber.d(t, "message").
if (throwableArgument != null && messageArgument != null) {
Expand Down