fix(desktop): declare no non-exempt encryption in Info.plist - #642
JakubAnderwald wants to merge 1 commit into
Conversation
Without ITSAppUsesNonExemptEncryption every macOS upload lands in App Store Connect as "Missing Compliance" and no TestFlight group can see it. fastlane used to set compliance after its processing wait, which the desktop lane now skips (#641). Build 56 for #623 was valid but invisible because of this. Mobile already declares the same in app.config.ts. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe macOS app declares exempt encryption use in its ChangesDesktop export compliance
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The macOS app metadata declares exempt encryption use, and the release path preserves that declaration for both build configurations. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
macOS TestFlight build 56 for #623 was uploaded and VALID, but no tester could see it. App Store Connect had it at Missing Compliance (
usesNonExemptEncryption: null), so neither internal group got it.Until now, fastlane answered the export-compliance question only after
upload_to_testflight's processing wait. Build 56's lane hung inside that wait (the #641 incident), so compliance was never set. #641 now skips that wait, which would have left every future macOS build uncompliant.Change
apps/desktop/macos/Drafto-macOS/Info.plist:ITSAppUsesNonExemptEncryption = false. Mobile already declares the same inapps/mobile/app.config.ts. The app only uses OS-provided HTTPS, which is exempt.Build 56 itself was fixed by hand: compliance set to
falsevia the App Store Connect API, and it's now In Beta Testing in Family and External users.Tests
scriptssuite 1692/1692,plutil -lintOK,pnpm lintandpnpm typecheckgreen.Takes effect on the next desktop build from the primary-checkout fossil after this merges (source only, no reinstall).
Parity: desktop-only (the mobile equivalent already exists).
🤖 Generated with Claude Code
Summary by CodeRabbit
Compliance
Tests