Verify support mail address#28
Merged
Merged
Conversation
This commit adds support for verifying that the support email is valid. While this can be bypassed if a dishonest admin party by modifying the support mail in KV store, it is a good feature that can help an honest ensure the email for their support system is valid. Some fixes include: - Refactoring the route state handling - The mailer now uses 24 hour period for mail validation links - Mailer now uses HTML to send verification links - Auth token generation and verification is now unified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for verifying that the support email is valid. While this can be bypassed if a dishonest admin party by modifying the support mail in KV store, it is a good feature that can help an honest ensure the email for their support system is valid.
Some fixes include: