awiesm3 links: correct feom→atm neighbour count and add R→RnfA link - #56
Merged
Conversation
Match the awiesm3 (N56) namcouple: the feom->atm direction (SST/ice/ currents) uses GAUSWGT U with 9 neighbours (1 9 2), not 25; and the runoff/calving atm->mapper link (R<nn> -> RnfA, GAUSWGT D 1 25 0.1) was missing. awiesm3_feom_links now returns the full 5-link set. Add submit_weightgen_..._regen.sh to regenerate just the two changed links onto an existing weight set.
The 9-neighbour default (90b1eec) is right for high-res atmospheres (TCO639) but broke TCO95/A096, whose deployed namcouple uses GAUSWGT U ... 25. A regen with 9 emitted rmp_feom_to_A096_GAUSWGT_9.nc, so OASIS fell back to a stale full-mesh _25 -> MCT column-count mismatch (208296 vs 211567) at the mesh increment. Key feom->atm on atm_grid: A096 -> 25 neighbours, else -> 9 (default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #55 (which merged the TCO639/NEXT config + weight-gen tooling). These two commits landed on the branch afterwards and carry the actual coupling-correctness fixes, validated against the awiesm3 N56 namcouple + its rmp files:
GAUSWGT Umap (SST/ice/currents back to the atmosphere) is1 9 2in the awiesm3 namcouple. The regeneratedrmp_feom_to_A640_GAUSWGT_9.nc(930,508,808 B) matches N56'srmp_feom_to_A640_GAUSWGT.nc(930,820,852 B) to within 0.03%.R<nn>→RnfArunoff link (GAUSWGT D 1 25 0.1) — runoff/calving from the atmosphere land grid onto the runoff-mapper grid.awiesm3_feom_linksnow returns the full 5-link set.Verified end-to-end: full 5-file rmp set generated (cdf2), reordered natural→dist_9600, and the reordered
dst_addressconfirmed a valid bijective relabel with weights byte-preserved.