Repository navigation
fix: don't record joins for complaints that don't exist - #227
Merged
Merged
Conversation
Complaint.join inserted the complaint_joins row first and only then found out, via the UPDATE, that there was no such complaint. The caller got a 404, but the row stayed. complaint_joins has no foreign key, so when a complaint with that id was created later, the same user or session was told "You have already joined this complaint" and saw it in their joined list, while supporter_count was never incremented. Check that the complaint exists before inserting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #226
What was wrong
Complaint.joininserted thecomplaint_joinsrow before finding out (via the UPDATE) that the complaint didn't exist. The caller got a 404, but the orphan row later made the real complaint report "already joined" for that user or session, with no supporter counted.Fix
Check that the complaint exists before inserting; return
null(the controller's existing 404 path) if it doesn't.Tests
New
backend/tests/complaintJoin.test.js: joins an id that doesn't exist and checks that nocomplaint_joinsrow was written. Fails onmain(one row found), passes with this change.npm testinbackend/: 79 tests, 79 pass.