Repository navigation
fix: let /assign auto-assign without a department - #230
Merged
Janani-bn merged 1 commit intoNov 15, 2026
Merged
Conversation
assignComplaint routes a complaint by issue type when autoAssign is true, but validateDepartmentAssignment rejected any request without a department first, so auto-assign could never be reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assignComplaintsupportsautoAssign: true, which picks the department from the complaint's issue type. ButvalidateDepartmentAssignmentran first and returned 400 wheneverdepartmentwas missing, so that branch was unreachable.The validator now lets the request through when
autoAssign === true. Manual assignment still requires a department, and a non-booleanautoAssignlike"yes"still gets validated.Tests
Added
backend/tests/departmentAssignment.test.js:main.autoAssigndoesn't bypass the checknpm testinbackend: 85 passed.Fixes #229