fix: handle symlinks in file browser #296
Merged
+552
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- used for symlinks, to determine if they link to a valid fsp
…; return redirect if found
…sp; return redirect if found
neomorphic
approved these changes
Jan 15, 2026
Member
neomorphic
left a comment
neomorphic
left a comment
There was a problem hiding this comment.
It doesn't look like there is anything new since our in person review, so it looks good to me. The tests look like they cover all the cases I can think of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup id: 86aegdjgw
This PR introduces logic to handle cases where a file path attempts to escape the root directory of a filestore (e.g., in the case of a symlink) by redirecting requests to the correct file share path (FSP) if possible. It does so by defining a new
RootCheckErrorexception, implementing a database lookup for FSPs based on absolute paths, and updating the/api/filesand/api/contentendpoints to utilize this logic. Tests are also added for the new function that looks up FSPs based on absolute paths, and for the behavior of the endpoints in the case of a symlink.When merged, this PR closes issue #293
@krokicki