This repository was archived by the owner on Mar 18, 2026. It is now read-only.
Feature/bookmark plans & sharing plans#11
Merged
Conversation
Owner
Author
|
Rebased off of history-mvp branch, because authentication is was working on that branch. Closed branch with login issues (system tests failed): #9 Corresponding frontend PR: Janooski/web#9 Successful system test: https://github.com/Janooski/web/actions/runs/15375863281 |
pheonix8
approved these changes
Jun 2, 2025
Collaborator
pheonix8
left a comment
pheonix8
left a comment
There was a problem hiding this comment.
I really don't like that we did a rebase, especially that we rebased with a dev / mvp branch. But because of the time running low, we should move on and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got Error 401 messages that weren't fixed after rebase from main. It rebased in branch dev/sharing-mvp into here, because there the login worked.