[19.0][IMP] pos_sale_picking_keep: Settle ordered quantities even if delivered#3
Merged
alan196 merged 1 commit intoJul 2, 2026
Conversation
When settling a sale order, the PoS deducts the already delivered quantity from each line, because it assumes it will deliver the remaining quantity itself. With this module the sale order pickings are kept and the PoS is only used to charge the order, so lines of already delivered orders were loaded with zero quantity (or even removed for products whose UoM is not groupable in the PoS, due to the line splitting logic of pos_sale). Load the ordered quantity instead, deducting only the quantity already invoiced to avoid charging twice.
Available types: 'task#', 't#' (case insensitive) Examples:
|
Available types: 'task#', 't#' (case insensitive) Examples:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When settling a sale order, the PoS deducts the already delivered quantity from each line, because it assumes it will deliver the remaining quantity itself. With this module the sale order pickings are kept and the PoS is only used to charge the order, so lines of already delivered orders were loaded with zero quantity (or even removed for products whose UoM is not groupable in the PoS, due to the line splitting logic of
pos_sale).Load the ordered quantity instead, deducting only the quantity already invoiced to avoid charging twice. Covered with a new tour-based test.
Same change submitted to OCA in OCA#1576 (migration PR, second commit).
Context: reported by Promovago when charging already-delivered sale orders (e.g. C00068) in the PoS.