Skip to content

[19.0][IMP] pos_sale_picking_keep: Settle ordered quantities even if delivered#3

Merged
alan196 merged 1 commit into
Jarsa:19.0from
Jarsa-dev:19.0-imp-pos_sale_picking_keep-settle-qty
Jul 2, 2026
Merged

[19.0][IMP] pos_sale_picking_keep: Settle ordered quantities even if delivered#3
alan196 merged 1 commit into
Jarsa:19.0from
Jarsa-dev:19.0-imp-pos_sale_picking_keep-settle-qty

Conversation

@alan196

@alan196 alan196 commented Jul 2, 2026

Copy link
Copy Markdown

When settling a sale order, the PoS deducts the already delivered quantity from each line, because it assumes it will deliver the remaining quantity itself. With this module the sale order pickings are kept and the PoS is only used to charge the order, so lines of already delivered orders were loaded with zero quantity (or even removed for products whose UoM is not groupable in the PoS, due to the line splitting logic of pos_sale).

Load the ordered quantity instead, deducting only the quantity already invoiced to avoid charging twice. Covered with a new tour-based test.

Same change submitted to OCA in OCA#1576 (migration PR, second commit).

Context: reported by Promovago when charging already-delivered sale orders (e.g. C00068) in the PoS.

When settling a sale order, the PoS deducts the already delivered
quantity from each line, because it assumes it will deliver the
remaining quantity itself. With this module the sale order pickings are
kept and the PoS is only used to charge the order, so lines of already
delivered orders were loaded with zero quantity (or even removed for
products whose UoM is not groupable in the PoS, due to the line
splitting logic of pos_sale).

Load the ordered quantity instead, deducting only the quantity already
invoiced to avoid charging twice.
@jarsabot

jarsabot commented Jul 2, 2026

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

@alan196 alan196 merged commit 317bc49 into Jarsa:19.0 Jul 2, 2026
2 of 4 checks passed
@jarsabot

jarsabot commented Jul 2, 2026

Copy link
Copy Markdown
    **WARNING**: Could not link to Odoo task. Record ID not found in the title of the MR, supported formats:
{ record type }#{ number }

Available types: 'task#', 't#' (case insensitive)

Examples:

  • task#123

  • i#123

@alan196 alan196 deleted the 19.0-imp-pos_sale_picking_keep-settle-qty branch July 2, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants