docs: HelperLifecycleManager comment — drop ~/log path placeholder#38
Open
JasonYeYuhe wants to merge 1 commit intomainfrom
Open
docs: HelperLifecycleManager comment — drop ~/log path placeholder#38JasonYeYuhe wants to merge 1 commit intomainfrom
JasonYeYuhe wants to merge 1 commit intomainfrom
Conversation
Codex review of v1.13.1 (PR #37): the HelperLifecycleManager docstring still mentioned `__HOME__` substitution for log paths ("the user's home directory (so log paths resolve correctly even on multi-user Macs)"). Phase 4E e2e fix already removed `~/Library/ Logs/...` `StandardOutPath` / `StandardErrorPath` from HelperAgent.plist (launchd doesn't expand `~`); helper logs via os_log instead. The stale comment was P3 risk that the next maintainer might reintroduce tilde paths. Replaced the substitution-era comment block with the current no-substitution design + an explicit warning not to reintroduce log path keys. embed_helper_in_archive.sh and CI's verify-archive-embedding job both reject tilde paths now, so the documentation aligns with the runtime guards. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex P3 cleanup from the v1.13.1 review:
HelperLifecycleManagerdocstring still mentioned__HOME__substitution for log paths ("the user's home directory (so log paths resolve correctly even on multi-user Macs)"). Phase 4E e2e fix already removed~/Library/Logs/...StandardOutPath/StandardErrorPathfromHelperAgent.plist(launchd doesn't expand~); helper logs via os_log instead. The stale comment was P3 risk that the next maintainer might reintroduce tilde paths.Replaced the substitution-era comment block with the current no-substitution design + an explicit warning not to reintroduce log path keys.
embed_helper_in_archive.shand CI'sverify-archive-embeddingjob both already reject tilde paths now, so the documentation aligns with the runtime guards.Scope
CLI Pulse Bar/CLIPulseCore/Sources/CLIPulseCore/HelperLifecycleManager.swiftfeedback_loginitem_launchagent_collision.mdfor the future Developer ID distribution work; both are inert under MAS distribution (Swift helper stripped pre-upload).🤖 Generated with Claude Code