-
Notifications
You must be signed in to change notification settings - Fork 2
#67+#141 Implement Authentication Service and DB versioning with Flyway #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
#67+#141 Implement Authentication Service and DB versioning with Flyway #145
Conversation
# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/service/acl/AclRulesLoader.groovy # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java
…nto feature/142-integrate-acl-groovy-based-engine-part-2
…ate-acl-groovy-based-engine-part-2
# Conflicts: # acl-groovy-dsl/src/main/groovy/javasabr/mqtt/acl/groovy/dsl/loader/AclRulesLoader.groovy
…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle
# Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle
…lyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle
…ing-with-flyway # Conflicts: # application/build.gradle # application/src/main/java/javasabr/mqtt/broker/application/config/MqttBrokerSpringConfig.java # settings.gradle
Test Coverage Report
|
authentication-api/src/main/java/javasabr/mqtt/auth/api/AuthenticationProvider.java
Outdated
Show resolved
Hide resolved
authentication-api/src/main/java/javasabr/mqtt/auth/api/CredentialsSource.java
Outdated
Show resolved
Hide resolved
authentication-api/src/main/java/javasabr/mqtt/auth/api/AuthenticationConfigException.java
Outdated
Show resolved
Hide resolved
...source-db/src/main/java/javasabr/mqtt/auth/credentials/source/config/DatabasePoolConfig.java
Show resolved
Hide resolved
| # https://mvnrepository.com/artifact/org.springframework/spring-core | ||
| spring = '6.2.15' | ||
| # https://mvnrepository.com/artifact/org.assertj/assertj-core | ||
| assertj = '3.24.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to have assertJ? When we write all trests on spock?
...ice/src/main/java/javasabr/mqtt/service/message/converter/ConnectToAuthRequestConverter.java
Outdated
Show resolved
Hide resolved
|
|
||
| import static javasabr.mqtt.broker.application.MqttClientFactory.generateClientId | ||
|
|
||
| abstract class ContextRunnerSpecification extends Specification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need it here?
| import static io.r2dbc.spi.ConnectionFactoryOptions.USER | ||
|
|
||
| @Configuration | ||
| class DatabaseTestSpringConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have it here?
| import java.nio.charset.StandardCharsets | ||
| import java.util.concurrent.CompletionException | ||
|
|
||
| class AuthenticationServiceTest extends ContextRunnerSpecification { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WTF
#67
The main goal of the PR is to prepare a module and class structures covering the most common authentication mechanisms, so it introduces the following entities: