Skip to content

Refactor core to align runtime and utility helpers#45

Open
GuTaoZi wants to merge 1 commit into
Jayfeather233:masterfrom
GuTaoZi:framework-only
Open

Refactor core to align runtime and utility helpers#45
GuTaoZi wants to merge 1 commit into
Jayfeather233:masterfrom
GuTaoZi:framework-only

Conversation

@GuTaoZi
Copy link
Copy Markdown
Contributor

@GuTaoZi GuTaoZi commented May 12, 2026

This pull request primarily focuses on improving code readability and consistency by reformatting and modernizing the code style across several files. The changes include updating brace placement, converting multi-line function definitions to single-line where appropriate, and standardizing the use of else statements. Additionally, some minor improvements were made to logging output and command formatting.

Code style and formatting improvements:

  • Converted multi-line function definitions and constructors in src/bots/shinxbot.cpp, src/bots/shinxbot.hpp, and src/bots/shinxbot_meta.cpp to single-line where possible, improving code compactness and readability. [1] [2] [3] [4]
  • Standardized the use of else by placing it on the same line as the closing brace of the previous if block, and updated related conditional formatting throughout src/bots/shinxbot_meta.cpp. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Logging and output improvements:

  • Improved logging output by ensuring formatted messages use explicit format strings in fmt::print calls in shinxbot::setlog.

Command and string formatting enhancements:

  • Broke up long command and error message strings for better readability and maintainability, especially in command construction and error reporting in src/bots/shinxbot_meta.cpp. [1] [2] [3] [4] [5] [6]

Configuration updates:

  • Changed the brace style in .clang-format from Stroustrup to Attach to enforce the new code style project-wide.

Include order:

  • Reordered includes in src/bots/shinxbot_meta.cpp to maintain a consistent and logical order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant