Loosen nicegui dep to unversioned named requirement#11
Merged
Conversation
The exact fork-SHA pin forced a waldoctl (and hence parol6) release on every /nicegui-combo-bump, and pip rejects differing direct-URL pins, so WC could never bump its combo SHA independently. waldoctl only uses the stable nicegui.binding API; the app layer owns the fork pin. Unversioned because fork installs report 0.0.0.postN, which any version floor would reject. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M7tEqGhaTqJV6ZxCXgMpFU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exact fork-SHA pin forced a waldoctl (and hence parol6) release on every
/nicegui-combo-bump, and pip rejects differing direct-URL pins for the same package — so WC could never bump its combo SHA independently (WC #20 CI is red on exactly this conflict).waldoctl only uses the stable
nicegui.bindingAPI, which none of the fork's open PRs touch; the app layer owns the fork pin. The requirement is unversioned because fork-SHA installs report0.0.0.postN(setuptools-scm can't see upstream tags in pip's clone), so any version floor would reject them and break resolution for WC.Suite: 89/89 green against the current combo (
eff7a1b9).Release intent: tag v0.6.2 after merge (parol6 v0.3.1 and WC's collision PR re-pin to it).
🤖 Generated with Claude Code
https://claude.ai/code/session_01M7tEqGhaTqJV6ZxCXgMpFU