Skip to content

fix(adopt_a_pet): match listing photographs to pet descriptions - #1

Merged
JeremyJC67 merged 2 commits into
JeremyJC67:review/pr-94-adopt_a_petfrom
sarendis56:fix/adopt-a-pet-photos
Sep 13, 2026
Merged

fix(adopt_a_pet): match listing photographs to pet descriptions#1
JeremyJC67 merged 2 commits into
JeremyJC67:review/pr-94-adopt_a_petfrom
sarendis56:fix/adopt-a-pet-photos

Conversation

@sarendis56

Copy link
Copy Markdown

Summary

Addresses the remaining pet-photo findings in WebHarbor #94. This focused follow-up targets the active review branch (#100), rebased onto its 1166ad6 tip.

  • Give all 20 listings their own photograph, with image dimensions of at least 480 px on both axes.
  • Correct the species/breed/coat mismatches, replace low-resolution thumbnails, and keep article banners separate from pet photographs.
  • Use nine photographs from the recorded reference material and eleven attributed Wikimedia Commons photographs, with per-image provenance and a linked Photo credits page. The supplementary photographs represent fictional benchmark pets; they are not asserted to be photographs of real adoptable listings.
  • Preserve every task, verifier, and non-image catalog field from the reviewer branch.

Paired assets

HF assets PR #67 now contains the matching images and seed image paths at 8316809f5eed94078c9b188e5c315f67df751be1. The archive uses only the supported adopt_a_pet/instance_seed/ and adopt_a_pet/static/images/ asset roots and excludes AppleDouble files and superseded images.

The code and asset update should land together. Keep the existing .assets-revision until the assets PR merges, then pin the immutable HF merge revision. This follow-up leaves that release step to the maintainers.

Verification

  • All 272 existing verifier tests passed.
  • 80 visible-browser photo checks passed: 20 listings at 1440, 768, 390, and 320 px. Navigation used the homepage search, pagination, and pet cards. No broken photos, horizontal overflow, or browser page errors were observed.
  • Checked each revised photo visually against the listing's species, breed appearance, and coat description.
  • Compared the old and revised seed catalogs: only the image column changed; SQLite integrity checks passed.
  • Rebased container build passed; 27/27 sites ready at startup.
  • Container reset returned ready: true; a direct byte comparison of the live and seed databases passed after reset.

Screenshots

Desktop — Archie now displays an Australian Shepherd photograph:

Archie desktop

Mobile — Olive now displays a Siamese photograph, distinct from Teddy's Poodle photograph:

Olive mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants