Recover fixes that were pushed after their PRs merged - #75
Merged
Merged
Conversation
After a failed process handover the pull, install and rebuild have all succeeded, but Retry re-ran updateFromSource from the top and aborted on the now no-op pull with a misleading 'already up to date' error. Remember that only the relaunch is outstanding and jump straight back to it. (cherry picked from commit 7b0af89)
When json_schema is rejected, json_object and plain fallbacks now append the schema to the conversation so compatible providers know the expected shape. Also advance to the next format when a 200 response contains unparseable text instead of retrying the same format. (cherry picked from commit 03afb8a)
…dget Detect post-export cap exceedance by comparing finished file bytes to sizeTargetBytes, show an explicit over-limit warning, and stop implying downscaling or overBudget alone guarantees the file fits. Update planner and ExportResult docs to note the bitrate floor can push output over cap. (cherry picked from commit ef5810b)
When the release workflow runs from a Release v commit or workflow_dispatch on main, winget-releaser falls back to github.ref_name (main) without an explicit release-tag. Read the version from package.json like the notes job and pass v$version. (cherry picked from commit a049ea5)
…fixes These fixes were pushed to their branches after the PRs had merged, so they never reached main: - Windows: only codex.cmd is run as a Codex shim; other .cmd launchers (e.g. a conda python.cmd) run through a shell (port of 646bd18). - Tests for the OpenAI schema fallback and the source-update restart retry (the latter fails on the previous code). - Release notes for all recovered fixes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
cmd.exe splits unquoted paths at spaces (a profile like C:\Users\Jane Doe or Program Files), so the recovered launcher fix still failed there. Pass one fully quoted command line instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
What does this change?
While cleaning up old branches, I compared every branch with its PR. Ten branches had one commit pushed after their PR merged, so it never reached
main. Six were already covered by later work or no longer needed. This brings in the other four, plus a winget release fix:7b0af89fix/dev-update-black-screen(#45)646bd18codex/video-quality-improvements(#59)codex.cmdis treated as a Codex shim on Windows; other.cmdlaunchers run via a shell. Ported by hand, since the file had changed03afb8acursor/openai-compatible-endpoints-627e(#56)json_objectand plain fallbacks include the schema; invalid JSON moves on to the next formatef5810bcursor/size-targeted-export-627e(#55)a049ea5cursor/winget-manifest-627e(#57)Cherry-picks keep
(cherry picked from commit …)trailers.How did you test it?
npm test(582). New tests cover the schema fallback and the restart retry. The retry test fails on the previous code.npm run typecheck,npm run lint🤖 Generated with Claude Code
Note
Medium Risk
Touches source-update relaunch, Windows process spawning for local Whisper/Codex, and the structured-output fallback path used across analysis—high user impact but scoped changes with new tests.
Overview
Bundles several fixes that never landed on
mainafter their original PRs merged, plus a small release-workflow tweak.Source checkout updates now remember when pull/build already finished but restart failed (
relaunchPending). A retry goes straight to Restarting… instead of pulling again and hitting “already up to date.”OpenAI-compatible analysis adds explicit schema text on
json_object/ plain fallbacks, validates parsed JSON before accepting a response, and retries the next format when the model returns prose or invalid JSON.On Windows, only
codex.cmdis resolved to the Codex JS entry; other.cmdshims (e.g. conda python.cmd) run through cmd.exe with properly quoted arguments via newcmdLine.Size-targeted exports clarify that
overBudgetis a quality warning, not a guarantee under the cap; the editor shows a dedicated message when the finished file’sbytesexceedsizeTargetBytes.The winget release job checks out the repo, reads
package.jsonfor the version, and passesrelease-tagto winget-releaser. CHANGELOG documents the fixes under [Unreleased].Reviewed by Cursor Bugbot for commit 747d72c. Bugbot is set up for automated code reviews on this repo. Configure here.