feat(media): adapt remaining external shapes (#120) - #121
Merged
Conversation
Add fixture-backed classification and injectable provider seams for file and LTI shapes. Preserve redacted stable references and retryable unsupported status. Assisted-by: GPT-5 Co-authored-by: Codex <noreply@openai.com>
Wait for Gallery content to advance, stop cumulative Load More when the displayed total is reached, and omit invalid legacy zero durations during green reconciliation. Assisted-by: GPT-5 Co-authored-by: Codex <noreply@openai.com>
jerome-queck
force-pushed
the
codex/issue-120-external-media-adapters
branch
from
August 17, 2026 04:24
5eec2b1 to
90496ce
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #120
Summary
Known external-tool adapters intentionally return unavailable/retryable outcomes until a safe provider acquisition path exists; the successful acquisition test uses an injected fixture adapter and does not touch authenticated services.
Validation
npm run lint— passnpm run format:check— passnpm test— 359/360 pass; the one failure is the existing environment-sensitivemedia-setupCLI test, which attempts the real /Volumes/RAID0/Media runtime and receives EPERM.Drift
#120 — Add adapters for remaining NTULearn external-media shapes: 4 of 4 criteria delivered, nothing beyond the brief.
Everything is ticked on the issue and in the PR.
Assisted-by: GPT-5
Co-authored-by: Codex noreply@openai.com