Repository navigation
ci: test on pull requests against Keras 3 and Keras 2 - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the push-only workflow, which tested Python 3.8 to 3.10 against whatever TensorFlow was latest, with jobs that run on pull requests and pushes to main.
Jobs
TF_USE_LEGACY_KERAS=1The Keras 3 failures are expected. They are #23:
add_weightreceives the name positionally inComplexConv, andComplexBatchNormalizationusesadd_update/K.in_train_phase, which Keras 3 removed. Merging this first means #24 and the batch-norm fix that follows can show their results in CI, and you can watch the Keras 3 jobs go green.Details
fetch-depth: 0, so setuptools-scm finds the tags.fail-fast: false, so one failing job doesn't cancel the rest. That cancellation hid the 3.8 and 3.9 results in the old workflow.astral-sh/setup-uv@v10.3.0, pinned to an exact tag because that action publishes no floating major tag.check-jsonschema --builtin-schema vendor.github-workflows).pre-commit.ci
The pre-commit.ci app runs on this repo but found no config, so every PR got "error during ci config". The new commit adds a
.pre-commit-config.yamlwith read-only hooks from pre-commit-hooks v6.0.0: check-yaml, check-toml, check-merge-conflict and check-added-large-files. Nothing gets reformatted, so it doesn't collide with #24..gitignorehas ignored every*.yamlfile since the 2017 import, which would have kept the config out of git. It now has one exception for this file; the blanket rule stays. All four hooks pass locally (uvx pre-commit run --all-files) and on pre-commit.ci.