Skip to content

refactor: comprehensive code quality improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luna161 wants to merge 23 commits into
base: main
Choose a base branch
from
Open

refactor: comprehensive code quality improvements #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
141b207
refactor: rename interface `operation` to PascalCase `Operation`
Luna161 May 9, 2026
20a9ebd
fix: make second parameter optional in Operation.exe to support unary…
Luna161 May 9, 2026
6d0c216
fix: replace `any` with proper constructor type in operate method
Luna161 May 9, 2026
7a0b5be
refactor: remove empty constructors from all operation classes
Luna161 May 9, 2026
80ff618
chore: remove debug console.log statements
Luna161 May 9, 2026
f5d65e9
refactor: replace custom power() function with ** operator
Luna161 May 9, 2026
dcd4258
fix: change decimalState comparison from `<=` to `===` in decimal()
Luna161 May 9, 2026
4683072
fix: use Math.trunc instead of Math.floor in backspace() for negative…
Luna161 May 9, 2026
4e48098
fix: add division by zero error handling in division, modulo, and wol…
Luna161 May 9, 2026
812b425
fix: remove `this.op` assignment from unary operations to prevent inc…
Luna161 May 9, 2026
ab422ff
fix: reset lastResult in setZero()
Luna161 May 9, 2026
ccad142
fix: reset this.op in clear()
Luna161 May 9, 2026
436f218
chore: remove redundant DOMContentLoaded click listener
Luna161 May 9, 2026
9357068
style: add missing semicolons throughout TypeScript source
Luna161 May 9, 2026
3c5d24e
fix: remove extra double quote in root2 onclick attribute
Luna161 May 9, 2026
7f54dd2
fix: correct alt texts on all icon images to match their operations
Luna161 May 9, 2026
b5c17b0
fix: correct typo .stong-text to .strong-text in CSS and HTML
Luna161 May 9, 2026
f01f20c
style: merge duplicate #calculator CSS rule blocks
Luna161 May 9, 2026
60b0fe9
style: remove pointless border-radius on body
Luna161 May 9, 2026
cc7a356
chore: remove commented-out defaults from tsconfig.json
Luna161 May 9, 2026
e953e1a
fix: correct main entry point to page/dist/script.js
Luna161 May 9, 2026
e259b93
chore: add /page/dist/ to .gitignore and remove compiled output from …
Luna161 May 9, 2026
175af4b
style: merge duplicate #numpad CSS blocks and remove commented-out .c…
Luna161 May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/node_modules
/.pnp
.pnp.js
/page/dist/
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "web-calculator",
"version": "1.0.0",
"description": "A small Test Projekt. The goal is to make it more complex step for step.",
"main": "myscripts.js",
"main": "page/dist/script.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
Expand Down
275 changes: 0 additions & 275 deletions page/dist/script.js
View file
Open in desktop

This file was deleted.

48 changes: 24 additions & 24 deletions page/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,36 @@
</div>
<div id="numpad">
<div class="column">
<div class="btn" onclick="Btn.modulo()"><img src="icons/percent.svg" alt="÷"></div>
<div class="btn stong-text" onclick="Btn.wolfram()">1/x</div>
<div class="btn stong-text" onclick="Btn.number(7)">7</div>
<div class="btn stong-text" onclick="Btn.number(4)">4</div>
<div class="btn stong-text" onclick="Btn.number(1)">1</div>
<div class="btn stong-text" onclick="Btn.flipNumber()">+/-</div>
<div class="btn" onclick="Btn.modulo()"><img src="icons/percent.svg" alt="modulo"></div>
<div class="btn strong-text" onclick="Btn.wolfram()">1/x</div>
<div class="btn strong-text" onclick="Btn.number(7)">7</div>
<div class="btn strong-text" onclick="Btn.number(4)">4</div>
<div class="btn strong-text" onclick="Btn.number(1)">1</div>
<div class="btn strong-text" onclick="Btn.flipNumber()">+/-</div>
</div>
<div class="column">
<div class="btn stong-text" onclick="Btn.ce()">CE</div>
<div class="btn stong-text" onclick="Btn.power2()">x²</div>
<div class="btn stong-text" onclick="Btn.number(8)">8</div>
<div class="btn stong-text" onclick="Btn.number(5)">5</div>
<div class="btn stong-text" onclick="Btn.number(2)">2</div>
<div class="btn stong-text" onclick="Btn.number(0)">0</div>
<div class="btn strong-text" onclick="Btn.ce()">CE</div>
<div class="btn strong-text" onclick="Btn.power2()">x²</div>
<div class="btn strong-text" onclick="Btn.number(8)">8</div>
<div class="btn strong-text" onclick="Btn.number(5)">5</div>
<div class="btn strong-text" onclick="Btn.number(2)">2</div>
<div class="btn strong-text" onclick="Btn.number(0)">0</div>
</div>
<div class="column">
<div class="btn stong-text" onclick="Btn.c()">C</div>
<div class="btn" onclick="Btn.root2()""><img src="icons/radical.svg" alt="÷">2</div>
<div class="btn stong-text" onclick="Btn.number(9)">9</div>
<div class="btn stong-text" onclick="Btn.number(6)">6</div>
<div class="btn stong-text" onclick="Btn.number(3)">3</div>
<div class="btn stong-text" onclick="Btn.decimal()">,</div>
<div class="btn strong-text" onclick="Btn.c()">C</div>
<div class="btn" onclick="Btn.root2()"><img src="icons/radical.svg" alt="÷">2</div>
<div class="btn strong-text" onclick="Btn.number(9)">9</div>
<div class="btn strong-text" onclick="Btn.number(6)">6</div>
<div class="btn strong-text" onclick="Btn.number(3)">3</div>
<div class="btn strong-text" onclick="Btn.decimal()">,</div>
</div>
<div class="column">
<div class="btn" onclick="Btn.backspace()"><img src="icons/delete.svg" alt="÷"></div>
<div class="btn" onclick="Btn.divide()"><img src="icons/divide.svg" alt="÷"></div>
<div class="btn" onclick="Btn.multiply()"><img src="icons/x.svg" alt="÷"></div>
<div class="btn" onclick="Btn.substract()"><img src="icons/minus.svg" alt="÷"></div>
<div class="btn" onclick="Btn.add()"><img src="icons/plus.svg" alt="÷"></div>
<div class="btn" onclick="Btn.equal()"><img src="icons/equal.svg" alt="÷"></div>
<div class="btn" onclick="Btn.backspace()"><img src="icons/delete.svg" alt="delete"></div>
<div class="btn" onclick="Btn.divide()"><img src="icons/divide.svg" alt="divide"></div>
<div class="btn" onclick="Btn.multiply()"><img src="icons/x.svg" alt="multiply"></div>
<div class="btn" onclick="Btn.substract()"><img src="icons/minus.svg" alt="minus"></div>
<div class="btn" onclick="Btn.add()"><img src="icons/plus.svg" alt="plus"></div>
<div class="btn" onclick="Btn.equal()"><img src="icons/equal.svg" alt="equal"></div>
</div>
</div>
</div>
Expand Down
Loading