Store data in account, so it persists on different firefox instances#43
Open
charlie572 wants to merge 6 commits into
Open
Store data in account, so it persists on different firefox instances#43charlie572 wants to merge 6 commits into
charlie572 wants to merge 6 commits into
Conversation
Owner
|
mate how did I miss this pull request. I am at the end of my PhD so I have neglected the Goose but I was working on something like this, possibly overcomplicating it compared to your PR. |
Author
|
Hi, thanks for looking at this. I've just tested it, and I noticed that it doesn't update immediately after synchronising. It only updates when you restart the browser. I'll try to fix it. |
added 3 commits
August 12, 2025 15:47
Otherwise, the message might persist after reloading, when it shouldn't.
Author
|
It should update immediately now. |
Owner
|
Could you fix the merge conflicts please, I've fixed unit testing up |
Author
|
I've resolved the merge conflicts, and changed the unit tests so they use browser.storage.sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8
I just changed browser.storage.local to browser.storage.sync.