fix(cd): OAuth token exchange requires client_id — read TS_OAUTH_CLIENT_ID - #16
Merged
Merged
Conversation
Tailscale's /api/v2/oauth/token rejects client_credentials requests without client_id (docs: both fields required). resolve_bearer() sent client_id="" — the OAuth path would have failed on first real use at the TAILSCALE_API_KEY swap. Read the (non-secret) id from TS_OAUTH_CLIENT_ID, fail loudly if a tskey-client secret is provided without it, and pass the Actions variable through in cd.yml.
✅ ACL ValidationValidationDiff against live |
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-deadline fix for the TAILSCALE_API_KEY→OAuth swap (hard deadline 2026-07-31): the tskey-client exchange in scripts/ts_auth.py posted client_id="" which Tailscale rejects (docs require both fields). Now reads the non-secret TS_OAUTH_CLIENT_ID Actions variable (set via
gh variable set TS_OAUTH_CLIENT_ID) and errors with a clear message if a client secret is supplied without it — instead of a cryptic 4xx during the deadline-window swap. Legacy tskey-api pass-through unchanged (current CD unaffected). Local checks: syntax + passthrough + guard behavior.