Skip to content

chore(mobile-expo): add CI lint, typecheck, and build for Expo app#206

Open
up-tandem wants to merge 1 commit intomainfrom
chore/205-expo-ci
Open

chore(mobile-expo): add CI lint, typecheck, and build for Expo app#206
up-tandem wants to merge 1 commit intomainfrom
chore/205-expo-ci

Conversation

@up-tandem
Copy link
Contributor

@up-tandem up-tandem commented Mar 5, 2026

Summary

  • Adds @forge/expo to the Turborepo affected-package detection in CI
  • Excludes @forge/expo from the monorepo-wide lint job (like other mobile packages)
  • Adds a new lint-expo CI job that runs lint (--max-warnings=0), typecheck, and build for the Expo app

Resolves #205

Contracts Changed

None

Regeneration Required

No

Validation

  • CI workflow syntax is valid
  • Job mirrors existing patterns for iOS and Android CI jobs
  • Gated on needs.affected.outputs.mobile_expo == 'true' so it only runs when Expo code changes

Test Plan

  • Open PR touching mobile/expo/ and verify the lint-expo job triggers
  • Open PR not touching mobile/expo/ and verify the lint-expo job is skipped
  • Verify monorepo-wide lint job excludes @forge/expo

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Enhanced CI pipeline to support Expo mobile packages in the build and test workflow
    • Added dedicated Expo validation stage for linting, type checking, and building

Add a dedicated lint-expo job to the CI workflow that runs ESLint,
TypeScript type checking, and build validation for the Expo app
(mobile/expo) when changes are detected via Turbo affected analysis.

- Extend affected job to detect @forge/expo changes
- Exclude @forge/expo from main build-and-test lint step
- Add conditional lint-expo job with lint, typecheck, and build steps

Resolves #96

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61fe5605-7216-4f5c-998e-e01a271e0c8d

📥 Commits

Reviewing files that changed from the base of the PR and between f800031 and 192ec5c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Walkthrough

The change introduces Expo mobile package support to the CI pipeline by expanding the affected-packs detection to include @forge/expo, excluding it from the generic lint job, and adding a dedicated lint-expo job for Expo-specific linting, typechecking, and building.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yml
Adds mobile_expo output to the affected job; includes @forge/expo in affected package filter; excludes Expo from monorepo-wide lint step; introduces new lint-expo job that performs lint with --max-warnings=0, typecheck, and build for Expo scope when changes detected.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Suggested labels

tooling

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly summarizes the main change: adding CI lint, typecheck, and build support for the Expo app, which directly matches the changeset.
Linked Issues check ✅ Passed The PR successfully implements all coding requirements from issue #205: detecting Expo changes via Turborepo, adding lint-expo job, excluding Expo from monorepo lint, and gating on mobile_expo output.
Out of Scope Changes check ✅ Passed All changes in the workflow file are directly related to adding Expo CI support as specified in issue #205, with no unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/205-expo-ci

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(mobile-expo): add CI lint, typecheck, and build for Expo app

1 participant