rd-gen: Delegate marshaller's write to class's method#587
Merged
Iliya-usov merged 1 commit intoJetBrains:masterfrom Feb 4, 2026
Merged
rd-gen: Delegate marshaller's write to class's method#587Iliya-usov merged 1 commit intoJetBrains:masterfrom
write to class's method#587Iliya-usov merged 1 commit intoJetBrains:masterfrom
Conversation
After unembedding generated models for RemDev and Rider, according to 5.4.4 (Access Control) of JVM Specification, protected properties of core models will not be available in companion object of the inherited models in the other packages (e.g. `TextControlModel` and `RiderLightweightTextControlModel`). Previously, it was considered as "same run-time package". This commit puts the `write` method implementation in the class to allow accessing protected field and methods
khbminus
force-pushed
the
khbminus/fix-protected-write
branch
from
1d40207 to
4607cf0
Compare
ForNeVeR
approved these changes
Feb 2, 2026
Iliya-usov
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After unembedding generated models for RemDev and Rider, according to 5.4.4 (Access Control) of JVM Specification, protected properties of core models will not be available in a companion object of the inherited models in the other packages (e.g.
TextControlModelandRiderLightweightTextControlModel). Previously, it was considered as "same run-time package".This commit puts the
writemethod implementation in the class to allow accessing protected field and methods