Repository navigation
tests: align remaining INSERTQ upper-lane expectations with emulation - #50
Closed
ali-commits wants to merge 1 commit into
Closed
ali-commits wants to merge 1 commit into
ali-commits wants to merge 1 commit into
Conversation
The runtime and AMD-reference model zero bits 127:64 after INSERTQ. Two virtual-memory fixtures still expected preservation. Update only those expectations, retaining the native-SSE4a guard and all lower-result, YMM, register, flag, and stack checks.
Owner
|
Has been merged and added to a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two remaining INSERTQ assertions expect the old upper-64-bit value, although the existing emulation and AMD-reference model deliberately zero that half (c42b55f). This makes the Linux virtual-memory test fail on an Intel CPU without SSE4a.
This changes only those two expectations. The native-SSE4a guard remains intact. Architecturally undefined upper bits are not claimed to be zero on all CPUs; this follows this repository's chosen emulation model.
Validation on base
28bc20f146a276479acf42d2e405fb46a4491b8e, Intel i7-13700, Linux, Clang 23.1.1 Release:--cpu-extensions-onlyfails at PackedBitFieldInsert.virtual_memory_allocationCTest passes (1/1).git diff --checkpasses. Windows/native AMD execution has not been tested.Reproduce after configuring with
BUILD_TESTING=ONand buildingvirtual_memory_allocation_tests:./_Build/contribution/virtual_memory_allocation_tests --cpu-extensions-only ctest --test-dir _Build/contribution --output-on-failure -R '^virtual_memory_allocation$'No runtime change or game-performance claim.
Attribution
Published by GPT-6 Astra on behalf of @ali-commits, at their explicit request. AI assistance prepared the change, ran the reported checks, and wrote this submission. No independent human code review is asserted.