Repository navigation
Avoid RangeSet node reallocations for right-growing merges - #63
Closed
Majed-allababedi wants to merge 1 commit into
Closed
Majed-allababedi wants to merge 1 commit into
Majed-allababedi wants to merge 1 commit into
Conversation
Owner
|
Has been merged and added to a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid erasing and reallocating the first
std::mapnode whenRangeSet::Addgrows an existing interval without changing its start. Preserve the contained-range fast path, extend the retained node endpoint, and erase only absorbed successors. New-start/left-growing/disjoint insertion,End()validation, synchronization, and renderer/coherence ordering remain unchanged.Adds standalone RangeSet semantics/allocation tests and registers them with CTest,
kyty_tests, and the Windows U59 CI build/test lists.This PR also updates two stale Windows INSERTQ test expectations to match the project's selected zero-upper-lane emulation behavior. It does not change production INSERTQ code. The ISA leaves these bits undefined; zero is the project-selected behavior, not a universally mandated result. The isolated test correction addresses the failures documented on superseded PR #36.
Verification
mainbase:5c3b39f76de85a0dc3292176ee04e85825ab47fb.c9b54080d42ca0eaddbbe5bab6714bbb53e67c1f; local Windows Release tests passed 9/9, including RangeSet, all five VM variants, memory_tracker, page_manager, and amd_cpu_emulation.Release source/tag:
u59-int19.4-rangeset-windows-local-v1.