Print an error message when a package isn't found when using -Si - #2718
Merged
Conversation
Jguer
approved these changes
Dec 21, 2025
Owner
|
I'm ok with it but there's a bunch of users that run CI environments and want yay to ignore all types of errors in missing packages. I think since this doesn't change the missing logic, we should be ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the second issue discussed in #2472. It uses the same solution to find missing packages as in #2717, so if both of these get merged, I can create a common function to not duplicate this logic.
A couple of notes on how
yay -Si <pkg>differs frompacman -Si <pkg>(not huge deals IMO):cmatrix,nonexistent,firefoxwill show the cmatrix info, then'error: package 'nonexistent' not found, then firefox info. Yay will print all packages not found first, then repo packages, then AUR packages due to the way the implementation is structured.Both of these are not big deals, but wanted to point them out in case. I did not update/add any tests as this is just for error printing, but can do so if that is desired.