Skip to content

test(ScrollRestoration-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance#3355

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
adityack477:test/scroll-restoration-accessibility
Jun 3, 2026
Merged

test(ScrollRestoration-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance#3355
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
adityack477:test/scroll-restoration-accessibility

Conversation

@adityack477
Copy link
Copy Markdown
Contributor

@adityack477 adityack477 commented Jun 3, 2026

… & Screen Reader Aria Compliance

Description

Fixes #2826

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

What changed

  • Created new file app/components/ScrollRestoration.accessibility.test.tsx with 5 test cases

Test cases

  1. Renders no DOM nodes that would disrupt screen reader document flow
  2. Preserves landmark role structure when mounted alongside semantic elements
  3. Does not interfere with heading hierarchy readable by screen readers
  4. Does not affect keyboard tab order of interactive elements
  5. Does not inject elements with aria attributes that could confuse assistive technology

How it works

  • Mounts ScrollRestoration alongside semantic HTML elements and verifies it returns null without disrupting the DOM
  • Checks landmark roles (banner, navigation, main, contentinfo) remain intact
  • Verifies heading hierarchy (h1 → h2 → h3) is preserved
  • Confirms interactive elements (Link, button, input) remain focusable in correct tab order
  • Asserts no aria-* attributes are injected by the component

Tests

All 5 new tests pass. All existing tests pass.

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 3, 2026

@adityack477 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@adityack477
Copy link
Copy Markdown
Contributor Author

@JhaSourav07 please review and add gssoc:approved label

@Aamod007 Aamod007 added GSSoC 2026 mentor:Aamod007 type:testing Adding, updating, or fixing tests level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 3, 2026
@JhaSourav07 JhaSourav07 added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points and removed level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 3, 2026
@JhaSourav07 JhaSourav07 merged commit 963a174 into JhaSourav07:main Jun 3, 2026
42 of 43 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

🎉 Congratulations @adityack477! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:exceptional Outstanding contribution with exceptional implementation quality, testing. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ScrollRestoration-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

3 participants