fix: Handle Nullable Map and Enum Mismatch in MarkTextOptions.kt#247
Merged
Conversation
JimmyDaddy
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Handle Nullable Map and Enum Mismatch in MarkTextOptions.kt
Description
This PR addresses two issues in
MarkTextOptions.kt:Nullable
ReadableMaphandlingReadableArray.getMap(index)returns a nullableReadableMap?, but was passed directly into theTextOptionsconstructor, which expects a non-nullReadableMap.✅ Fixed using Kotlin's safe call with
let { ... }, and explicitly throwingMarkerErrorif null.Incorrect enum usage
MarkerErrorexpects the first argument to be of typeErrorCode, but aStringliteral"NULL_MAP"was passed instead.✅ Fixed by adding a new
ErrorCode.NULL_MAPenum value and using it explicitly in the constructor.Changes
ErrorCode.NULL_MAPto theErrorCodeenum.MarkTextOptions.ktto:ReadableArray.MarkerError(ErrorCode.NULL_MAP, ...)instead of passing a raw string.Impact
NullPointerExceptionduring runtime.Test
watermarkTextsinput