Skip to content

Fixes#3

Open
makigumo wants to merge 5 commits into
JimmyStones:mainfrom
makigumo:fixes
Open

Fixes#3
makigumo wants to merge 5 commits into
JimmyStones:mainfrom
makigumo:fixes

Conversation

@makigumo

@makigumo makigumo commented Jul 14, 2022

Copy link
Copy Markdown

Hi, while playing around on macOS with latest verilator (4.224) I got some issues, which I'm trying to resolve with this PR.
These changes allowed me to build and run this on macOS (Intel).

Here are the changes and their respective commits.

  • Missing files (9b0c361)

    • Commit 4e1d3d3 deleted files required for linux/macOS, namely imgui_impl_opengl2.* and imgui_impl_sdl.*.
  • While compiling sim_input there were some error. (9b3789c)

  • Verilator gave some warnings and exited when using make (bd63503)

    %Warning-DEPRECATED: Option -O<letter> is deprecated. Use -f<optimization> or -fno-<optimization> instead.
                         ... For warning description see https://verilator.org/warn/DEPRECATED?v=4.224
                         ... Use "/* verilator lint_off DEPRECATED */" and lint_on around source to disable this message.
    %Warning-UNOPTFLAT: ../rtl/../rtl/centipede.v:223:16: Signal unoptimizable: Feedback to clock or circular logic: 'top.uut.v_counter'
      223 |    reg [7:0]   v_counter;
          |                ^~~~~~~~~
    %Warning-UNOPTFLAT: ../rtl/../rtl/centipede.v:916:15: Signal unoptimizable: Feedback to clock or circular logic: 'top.uut.tb_mux'
      916 |    wire [3:0] tb_mux;
          |               ^~~~~~
                        ../rtl/../rtl/centipede.v:916:15:      Example path: top.uut.tb_mux
                        ../rtl/../rtl/centipede.v:938:19:      Example path: ASSIGNW
                        ../rtl/../rtl/centipede.v:919:25:      Example path: top.uut.tb_h_ck
                        ../rtl/../rtl/centipede.v:943:4:      Example path: ACTIVE
                        ../rtl/../rtl/centipede.v:943:4:      Example path: ALWAYS
                        ../rtl/../rtl/centipede.v:916:15:      Example path: top.uut.tb_mux
                        ../rtl/../rtl/centipede.v:933:18:      Example path: ASSIGNW
                        ../rtl/../rtl/centipede.v:916:15:      Example path: top.uut.tb_mux
    %Warning-UNOPTFLAT: ../rtl/../rtl/p6502.v:353:16: Signal unoptimizable: Feedback to clock or circular logic: 'top.uut.p6502.ma'
      353 |    wire [15:0] ma;
          |                ^~
                        ../rtl/../rtl/p6502.v:8:1: ... note: In file included from p6502.v
    %Warning-UNOPTFLAT: ../rtl/../rtl/centipede.v:222:16: Signal unoptimizable: Feedback to clock or circular logic: 'top.uut.h_counter'
      222 |    reg [11:0]  h_counter;
          |                ^~~~~~~~~
    
  • top__DOT__ce_pix was no longer available (0f94a8f)
    Not sure this is the right approach, but was the easiest. Update as per Model interface changes in version 4.210

  • Fix compiler warning (1e9748b)

    ../sim/sim_bus.cpp:69:94: warning: data argument not used by format string [-Wformat-extra-args]
                            console.AddLog("Starting download: %s %d", currentDownload.file.c_str(), ioctl_next_addr, ioctl_next_addr);
                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~
    

@JimmyStones

Copy link
Copy Markdown
Owner

Hi - this all looks cool, I only use 4.204 so should probably upgrade all my projects if it doesn't break anything badly! Just on holiday at the moment so will check this out properly next week and make sure it still works for me then I'll merge it 👍

@JimmyStones JimmyStones reopened this Jul 14, 2022
@JimmyStones

Copy link
Copy Markdown
Owner

(managed to accidentally close that trying to reply on my phone, oops!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants