Fixes#3
Open
makigumo wants to merge 5 commits into
Open
Conversation
Owner
|
Hi - this all looks cool, I only use 4.204 so should probably upgrade all my projects if it doesn't break anything badly! Just on holiday at the moment so will check this out properly next week and make sure it still works for me then I'll merge it 👍 |
Owner
|
(managed to accidentally close that trying to reply on my phone, oops!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, while playing around on macOS with latest verilator (4.224) I got some issues, which I'm trying to resolve with this PR.
These changes allowed me to build and run this on macOS (Intel).
Here are the changes and their respective commits.
Missing files (9b0c361)
imgui_impl_opengl2.*andimgui_impl_sdl.*.While compiling
sim_inputthere were some error. (9b3789c)Verilator gave some warnings and exited when using
make(bd63503)top__DOT__ce_pixwas no longer available (0f94a8f)Not sure this is the right approach, but was the easiest.Update as per Model interface changes in version 4.210Fix compiler warning (1e9748b)