Skip to content

site: D4 review fixes; D1 deployed URL - #29

Merged
Jimuelle07 merged 3 commits into
mainfrom
feat/d4-review-fixes
Nov 12, 2026
Merged

Jimuelle07 merged 3 commits into
mainfrom
feat/d4-review-fixes

Conversation

@helenaherrero515

Copy link
Copy Markdown
Collaborator

Ace's two review fixes on #24, which merged at dc7948f before they were pushed.

  • Daily-cap caveat: the Results caveat now says 500 tUSDC is committed per UTC request day, and payouts on one day can include holds committed the day before (sdd.md).
  • Red-team calls: the red-team row reads Jev and classifier calls per payment from redteam-results.json instead of hardcoding them; a test checks it.

cd site && npm test 28/28, npm run build passes.

@Lanceace5432 these are your two points from #24.

Review fixes from Ace on PR #24: the red-team row reads jev/classifier calls per payment from redteam-results.json, and the caps caveat says 500 tUSDC is committed per UTC request day, with payouts that can include the previous day's holds (sdd.md).
sprints.md marks D1 done with the deployed URL; site/README.md records the Pages project (eclipse), the live URL and the redeploy command.
@helenaherrero515 helenaherrero515 changed the title site: D4 review fixes (red-team calls from JSON, daily cap wording) site: D4 review fixes; D1 deployed URL Nov 12, 2026
@helenaherrero515

Copy link
Copy Markdown
Collaborator Author

Added the D1 record: sprints.md marks D1 done, deployed at https://eclipse-20v.pages.dev/ (Cloudflare Pages project eclipse, from main 38aeaf0), and site/README.md has the live URL and the redeploy command. The project isn't connected to GitHub, so the site needs a redeploy after this merges.

@helenaherrero515

Copy link
Copy Markdown
Collaborator Author

@dsmipritzc D2 copy approval: the "How it works" section is live at https://eclipse-20v.pages.dev/#how (diagram, allow/hold/block explorer, and the amount-safety table under Safety). It's already merged (#14), so please just reply here with "D2 approved" or list any fixes. One more for D5: does the injection classifier run on the testnet checker, or only in the eval?

@dsmipritzc

Copy link
Copy Markdown
Collaborator

D2 approved. The injection classifier runs on the testnet checker because the .env.testnet file (committed in the feat/d4-d5-results-copy branch) sets INJECTION_ENABLED=true. It will also be used by any evaluation that loads the same testnet configuration.

@helenaherrero515

Copy link
Copy Markdown
Collaborator Author

@Jimuelle07 this PR is ready for your review and merge.

Done in this PR

Also settled on this thread

  • D2: Rc approved the "How it works" copy (comment above).
  • D5: Rc confirmed the injection classifier runs on the testnet checker (.env.testnet sets INJECTION_ENABLED=true, 14177c8), which was the last open question on the copy pass.

Still needed

@Jimuelle07
Jimuelle07 merged commit 3bd606b into main Nov 12, 2026
1 check passed
@Jimuelle07
Jimuelle07 deleted the feat/d4-review-fixes branch November 14, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants