Repository navigation
site: diagram survives ad blockers (rename ad-* classes) - #42
Merged
Merged
Conversation
EasyList hides .ad-box, .ad-title, .ad-label and #ad-head on every site, so with an ad blocker the payment-path diagram lost its boxes, titles, arrow labels and arrowheads. Renamed the whole ad/ad-* prefix to pp/pp-*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EasyList generic rules (
##.ad-box:not(#ad-banner):not(:empty),##.ad-title,##.ad-label,###ad-head) hid the payment-path diagram's boxes, titles, arrow labels and arrowheads for anyone with an ad blocker. Renamed thead/ad-*prefix topp/pp-*in ArchitectureDiagram.jsx, styles.css, motion.js.Verified: npm test 45/45, npm run build; with all 27,542 generic hide rules from EasyList, AdGuard Base and uBlock filters injected, no page element matches at 1440 or 390 px and the diagram renders fully.