Skip to content

Remove outdated Python2 code#197

Open
Rotzbua wants to merge 1 commit intoJohannesBuchner:masterfrom
Rotzbua:remove_python2_code
Open

Remove outdated Python2 code#197
Rotzbua wants to merge 1 commit intoJohannesBuchner:masterfrom
Rotzbua:remove_python2_code

Conversation

@Rotzbua
Copy link
Copy Markdown

@Rotzbua Rotzbua commented Oct 24, 2023

Change

  • Remove outdated Python2 code
  • Remove six package

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 24, 2023

Coverage Status

coverage: 87.805% (-0.04%) from 87.847% when pulling 1849bc4 on Rotzbua:remove_python2_code into 5e9ef5d on JohannesBuchner:master.

Remove `six` package
@Rotzbua Rotzbua force-pushed the remove_python2_code branch from 8bebb8d to 1849bc4 Compare October 24, 2023 17:25
@JohannesBuchner
Copy link
Copy Markdown
Owner

imagehash had Python 2 support much longer than other packages, and it helped a number of users stuck on ancient systems that do not receive updates. I had PRs from several people over the years trying to remove it and calling it outdated.

Unfortunately it has basically become impossible to run CI against such old versions now. So I think we may have to go with the times and say goodbye to Python 2 support at this point and recommend the affected users to use old versions.

@JohannesBuchner
Copy link
Copy Markdown
Owner

Hi @Rotzbua, sorry for picking this up so late. I'd be happy to merge this, but I see that there is a conflict. Can you please fix it?

@Rotzbua
Copy link
Copy Markdown
Author

Rotzbua commented Feb 3, 2025

I think it should first be clearly defined which python versions are supported 219 before migrations to a current modern python code are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants