Repository navigation
fix(holdem): add droppedAt to the winner test fixture so typecheck passes - #87
Merged
Merged
Conversation
…sses on main Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1mCwe46FiQjtWLVY588e5
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Main currently fails typecheck at tests/texasholdem.test.ts (payee helper missing droppedAt), which turns CI red on every open PR including #83, #84 and #86. Merging this unblocks them; they then need a rebase onto main. Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main fails
pnpm typecheckbecause a test fixture lacks the requireddroppedAtfield.Changes
droppedAt: nullto thepayeehelper.Why
The per-winner banner change and the disconnect pruning change landed separately; together they leave the fixture one field short, so every open PR fails CI.
Testing
pnpm typecheckandpnpm testpass locally.Notes
Test-only change.