Skip to content

WIP: Show context#23

Open
JonathonReinhart wants to merge 2 commits intomasterfrom
11-context
Open

WIP: Show context#23
JonathonReinhart wants to merge 2 commits intomasterfrom
11-context

Conversation

@JonathonReinhart
Copy link
Copy Markdown
Owner

No description provided.

This shows the hex row where the match begins.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 29, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2df194f). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   76.19%           
=========================================
  Files             ?        1           
  Lines             ?      252           
  Branches          ?        0           
=========================================
  Hits              ?      192           
  Misses            ?       60           
  Partials          ?        0
Impacted Files Coverage Δ
bgrep.c 76.19% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df194f...e2ee1a8. Read the comment docs.

@JonathonReinhart
Copy link
Copy Markdown
Owner Author

JonathonReinhart commented Dec 29, 2017

Here's a first stab:
image

It's a little lacking in a few ways:

  • Only one match per line is shown. It's going to be much more work to combine matches in a single row, but still keep the same left-hand output as before.
  • It only shows the start of the match, in the event that it spans multiple rows.
  • I'm not thrilled with the way the additional row starting address looks.

@JonathonReinhart JonathonReinhart mentioned this pull request Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants