Open
Conversation
This causes revisions that take long to provision to get terminated
Joon-L
requested changes
Dec 13, 2019
| @@ -1,4 +1,9 @@ | |||
| # Knative Serving | |||
| HACK RELEASE THIS UGLY UGLY FORK: | |||
| 1. get docker secretes to viennadroptest | |||
Owner
There was a problem hiding this comment.
Maybe add a comment on why this hack is needed?
| # $KO_DOCKER_REPO is the registry containing the images to tag with $TAG. | ||
| # Parameters: $1..$n - files to parse for images (non .yaml files are ignored). | ||
| function tag_images_in_yamls() { | ||
| echo "yeah" |
| function tag_images_in_yamls() { | ||
| echo "yeah" | ||
| if [[ -n ${AZ_ACR_NAME} ]]; then | ||
| echo "haha" |
|
|
||
| function tag_images_in_yamls_acr() { | ||
| #[[ -z ${TAG} ]] && return 0 | ||
| local XTAG="4eae16e681237d15dbcb4a22442e559e05ec3c30" |
Owner
There was a problem hiding this comment.
Why is that image tag fixed with some hash?
| @@ -0,0 +1,1890 @@ | |||
| apiVersion: v1 | |||
Owner
There was a problem hiding this comment.
I don't think this yaml has to be part of the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes