Use environment variables for movehub address#12
Open
gbshahaq wants to merge 3 commits intoJorgePe:masterfrom
Open
Use environment variables for movehub address#12gbshahaq wants to merge 3 commits intoJorgePe:masterfrom
gbshahaq wants to merge 3 commits intoJorgePe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly - thanks from a LEGO employee for getting this running. I had a Pi Zero W, and had failed in getting the repo from undera working, and then i found yours.
Will use it as a teaching aid for my child - and for me.
For the request - I just thought to add the MAC of the hub as an environment variable, rather than hardcode it. It's not going to change for me, but makes the sharing of code examples more straightforward