Support SQLAlchemy polymorphic / table inheritance - #54
Merged
Merged
Conversation
zamax14
marked this pull request as ready for review
June 29, 2026 08:18
zamax14
marked this pull request as draft
June 29, 2026 08:20
zamax14
marked this pull request as ready for review
June 29, 2026 08:21
…e-edges # Conflicts: # tests/conftest.py # tests/test_introspect.py
Deduplicating FK edges by (from_table, to_table) removed every foreign key between a child and its inherited parent, not just the join column, so business relationships to the same parent silently vanished from the diagram. Match on the fk_column too, and resolve the join column as the child primary key that references the parent. Drop the unreachable "single" strategy branch: single-table inheritance is skipped earlier because parent and child share a table. Move the edge-kind and strategy literals into constants/relationships.py, and split the inheritance and cardinality schemas out of conftest.py.
…e-edges Conflict in tests/conftest.py: develop added the column-comments fixture where this branch had moved the cardinality schema out. Kept both by extracting the comments schema into tests/fixtures/comments.py.
Owner
|
Fix: inheritance dedupe dropped unrelated foreign keys The dedupe matched on Now dedupes on |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
.venv/bin/python -m pytest tests/test_introspect.py tests/test_html_renderer.py tests/test_renderer.py.venv/bin/python -m pytestDocumentation