Skip to content

refactor(ue_mcp): rename logging.py -> ue_logging.py (stop shadowing stdlib) - #12

Merged
JosephOIbrahim merged 2 commits into
masterfrom
chore/unshadow-logging
Jul 2, 2026
Merged

refactor(ue_mcp): rename logging.py -> ue_logging.py (stop shadowing stdlib)#12
JosephOIbrahim merged 2 commits into
masterfrom
chore/unshadow-logging

Conversation

@JosephOIbrahim

@JosephOIbrahim JosephOIbrahim commented Jul 2, 2026

Copy link
Copy Markdown
Owner

What

  • Renames ue_mcp/logging.py to ue_mcp/ue_logging.py (100% rename, zero content change) and updates the single import in ue_mcp/mcp_server.py
  • Adds .gitignore entries for local-only tooling (files.zip, cozy.spec.yaml, .planning/fieldhouse/)

Why

The module name shadowed Python's stdlib logging, which is a latent import-order hazard for anything importing within the ue_mcp package.

Verification

python -m pytest -q: 415 passed.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Updated server logging setup to use the correct logging configuration, helping improve startup consistency.
  • Chores

    • Expanded ignore rules for internal tooling artifacts so local/generated files are no longer tracked.

…stdlib)

Commits the in-flight atomic rename: module + the one import line in
mcp_server.py, plus .gitignore entries for local fieldhouse tooling.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@JosephOIbrahim, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 821625fc-18e6-480b-a32e-c45cdae98fa1

📥 Commits

Reviewing files that changed from the base of the PR and between 87a8a06 and 8d899f2.

📒 Files selected for processing (1)
  • ue_mcp/mcp_server.py
📝 Walkthrough

Walkthrough

This PR adds three new ignore patterns to .gitignore for Fieldhouse internal tooling artifacts and corrects an import statement in mcp_server.py to reference ue_mcp.ue_logging instead of ue_mcp.logging.

Changes

Repo hygiene and import fix

Layer / File(s) Summary
Gitignore additions for Fieldhouse tooling
.gitignore
Adds a new comment block and ignore entries for files.zip, cozy.spec.yaml, and .planning/fieldhouse/.
Logging import path correction
ue_mcp/mcp_server.py
Updates the configure_logging import source from ue_mcp.logging to ue_mcp.ue_logging.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main refactor: renaming the logging module to avoid stdlib shadowing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/unshadow-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@JosephOIbrahim
JosephOIbrahim merged commit 35268c3 into master Jul 2, 2026
3 checks passed
@JosephOIbrahim
JosephOIbrahim deleted the chore/unshadow-logging branch July 2, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant