Fix factory PR authentication and automatic label enrollment - #2966
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factory PRs can stall because PR creation uses
github-actions[bot]even though pushes use a trusted token, leaving Actions awaiting approval and CodeRabbit skipping review. Repository PRs missing factory labels also remain outside the review/merge queue.Use
PR_REBASE_TOKENfor PR creation while preserving workflow-token authentication for controller operations. Extend the trusted issue/PR reconciler to enroll eligible repository PRs on open, reopen, ready-for-review, and unlabel events and in its existing 15-minute sweep. Preserve unrelated labels and existing owner/stage; default missing ownership tofactory:unowned, recover missing stage from trusted exact-head review verdicts, and otherwise requestfactory:review. Exclude forks, drafts, Dependabot, and Renovate. Complete metadata is left untouched; green checks alone never establish readiness.Validation: all 22 authentication and visibility/enrollment Node tests passed locally, along with shell syntax, factory roster validation, and
git diff --check. CI runs the regression suites. PR #2963's blocked CI and repair-guard runs were approved and stale ownership released.