Fix missing greenlet in production migration runtime - #2968
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy Production fails at Alembic environment loading because the locked SQLAlchemy 2.1 runtime omits greenlet. Declare
sqlalchemy[asyncio]in the production dependencies and update the lockfile so both migrations and the async application install it.Add a separate PR CI job using the exact production install (
uv sync --locked --no-dev) to import the async models and migrate a fresh PostgreSQL database. Include this job in CI Summary, lock the dependency contract with regression coverage, and document why dev installs can mask the failure through Playwright.The full local push validation also exposed inherited Git hook settings breaking temporary-repository tests. Clear repository-local Git environment before the pre-push gates and add a regression test; all existing gates remain enabled.
Validation:
d1aa29806941.uv sync --locked --no-default-groups) passed an async PostgreSQL query.ruff check .andty check --error-on-warningpassed.--no-verifyat Josh's explicit instruction while checks continue.Addresses #2965. Keep the issue open until a subsequent main Deploy Production run confirms migration and deployment success.
Closes #2967.