Repository navigation
chore: stop tracking dist/ and release 2.8.0 - #90
Merged
Merged
Conversation
Automated verification
typechecktestsbuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dist/(260 generated files removed from the index) and adddist/to.gitignore.dist/or compares it with the index.2.8.0and add a changelog entry explaining that installs are unchanged because the existingpreparescript buildsdist/where the package is consumed.AGENTS.mdso it no longer claimsdist/is committed or sync-checked.Why
Committed build output forced every PR touching
src/to include regenerated files and made reviews noisy. The build is reproducible from source, and npm already runspreparefor git installs, so trackingdist/added no safety.Install paths (verified)
npm packafternpm run buildproduces a tarball with 260dist/files and nosrc/; installing it in a clean project createsnode_modules/.../dist/index.jsand the plugin loads under Bun (id,setup,server).npm install github:...: installinggithub:JoshRob297/opencode-antigravity-auth#JoshRob297/task-t-dist1in a clean project runsprepare, createsdist/index.js, and the plugin loads under Bun.npm ciin a clone with zero trackeddist/files buildsdist/index.js;npm run typecheckpasses.Not verified / known issue
opencode plugin add github:...fails in this environment withNpmInstallFailedError: git dep preparation failedfrom OpenCode 2.2.6's embedded npm. The same failure reproduces on the unchanged base commit (including with a writableHOMEand full filesystem access), so it is an OpenCode/environment issue, not caused by removingdist/. The underlying npm git install it delegates to was verified directly.npm testcurrently has one pre-existing timing failure:src/v2/adapter.test.ts > transport failure circuit breakertakes ~6.7s locally and hits Vitest's 5s default. It fails identically on the base commit, and the full suite passes with--testTimeout=30000(1172 passed). This PR does not touchsrc/.Verification run