Merge upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env can only exist on command steps and trigger steps under build.env
…tion prevent incorrect interpolation of env on trigger steps
Without this feedback we're left simply with this vague output in Buildkite. > POST https://agent.buildkite.com/v3/jobs/<redacted>/pipelines: 500 There was an unknown error uploading these steps. Please email us at support@buildkite.com and include this UUID `<redacted>` so we can investigate and get it fixed. (Attempt 1/60 Retrying in 5s)
The `skx/github-action-build` GitHub Action has a hardcoded dependency on the `golang:latest` Docker image. With the the release of go1.18 some of our dependencies no longer compile on all MacOS. This PR updates some dependencies patch versions as well the bumping `golang.org/x/sys v0.0.0-20220319134239-a9b59b0215f8` to resolve sirupsen/logrus#1320. See https://github.com/chronotc/monorepo-diff-buildkite-plugin/runs/5638741275?check_suite_focus=true#step:12:19
Fix failing MacOS builds
* Add support for group steps Fixes adikari#82
…, review, test, infra (adikari#90) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
…adikari#84) * bugfix: add more logic to determine arch for download in command hook * bugfix: make command hook download darwin binary on mac * enhancement: add kernel allow list for uname value validation * enhancement: make nice error messages for bad arch/kernel
…o-diff's config has been identified (adikari#92) * Don't unmarshall other plugin configs into Plugin struct until monorepo-diff's config has been identified * make parseEnv return an error if parsing fails.
* this works, but not for straight bool value.
* Handle both SoftFail: SoftFail{} and SoftFail: bool cases.
* treat `soft_fail` as an array of maps, which it's supposed to be.
* i like init better.
* plugin tests
* in go we trust
* fix tests
Co-authored-by: xzyfer <michael@mryum.com>
buildkite allows both of these keys, and allows them as lists of strings in addition to just strings Fixes: adikari#103
Support both "commands" and "command" key, of any type
use log.Fatalf when logging error
Allow all tags when specifying the agent on a step
Without this `make test` can run tests against a stale image.
Rebuild plugin_test in the Makefile
Encode wait and hook steps with go-yaml
* doc: update readme version * fix build * fix readme
* allow users to upload notifications * feat: add nix for portability * feat: add sha256 * feat: fix typo in struct * fix: use correct exe path * match plugin key more loosely * fix: use Contains instead of hasPrefix * fix: get rid of fmt * try: printing * try: printing * try: empty interface * revert string matching * revert string matching pt2 * chore: remove flake files * chore: remove logs * add email notification config * test soft fail * test: generated pipeline * support notifications * chore: update e2e tests * chore: test bats * chore: update e2e * improve build Co-authored-by: subash <me@subash.com.au>
* chore: update e2e test * chore: update plugin yml * chore: remove test and lint from e2e tests * chore: add log level
* fix step notifications * generate pipeline with top level notify * parse pipeline notification from config * update plugin definition
* fix failing tests * test script * diff command supports eval * enable logging in tests * upgrade version in readme
* Add support to pass build meta_data in trigger steps * fix bats tests * add test for pipeline input * fix bats tests --------- Co-authored-by: Iaroslav Ciupin <iaroslav@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're a couple versions behind, lets maybe upgrade our version to match upstream?