Add workspace tab bar with session chrome - #11
Merged
Conversation
Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
- Persist the desktop session id on every saved tab (sid only when the engine persisted the conversation); restore reuses the id, spawning empty windows fresh, so a saved chat split survives switches/restarts - Serialize workspace swaps with a busy flag + generation token; disable the workspace tab bar while one is in flight - Re-validate nested tab chrome in sanitizeProjects; reject url(...) attribute values in sanitizeSvg - Use i18n strings for workspace/sidebar aria-labels Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace is now a first-class virtual desktop: a tab bar at the top of the canvas, a Default workspace plus user-created ones, and each workspace still owns its mosaic of session windows. Workspaces and sessions can be renamed and given a tag color plus icon (builtin set, slug, or sanitized SVG). The sidebar workspace dropdown is gone so there is only one switcher. Also slims Composer (screenshot/record removed; extras behind ⋯) and adds sidebar session search.
Scope
isDefault/color/iconon workspaces (file version stays 1; old files promote the first workspace to default). Sessioncolor/icon/titleLockedpersist with project tabs.WorkspaceTabs, shared chrome popover, mosaic/sidebar session chrome, drag-select fix on tabs.Ship-ready?
Not yet. Unit tests and
pnpm checkare green; GUI walkthrough and a second-pass review are still outstanding on this draft.Needs review?
Yes. Focus on persist/parse of chrome (especially SVG sanitizer), default-workspace delete/switch, and whether titleLocked still allows first-message titles for new sessions.
Review preconditions
cursor/workspace-desktops-17c0on currentmain(canvas mosaic; right dock must stay gone).pnpm testandpnpm checkshould be green.Test results
pnpm test: 28 files, 451 tests passed.pnpm check: 0 errors.