Unify agent sessions and redesign the model picker - #12
Merged
Conversation
Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent sessions are one tab type. TUI/ACP are no longer listed as create-tab options; the coding agent is chosen inside a session. Composer no longer uses a ⋯ overflow: model click opens a popup (agent rail when unlocked, then models with hover thinking chips), voice sits next to a smaller circular send, and approval / context / git branch live in a footer strip under the card.
Scope
+/ empty canvas / palette / sidebar: only “创建 Agent 会话”. Persistedtui:*tabs still render; they are not offered as new options.AgentModelPopover: left = coding-agent icons (hidden once the session is locked after first message or restore); center = that agent’s models; hover a model to pick a thinking level (chips, not a slider).Ship-ready?
Not yet. Unit tests are green; GUI walkthrough and review are still outstanding on this draft.
Needs review?
Yes — especially backend switch from the popover rail (does the picker survive ChatState swap?), locked vs unlocked rail, and that TUI/ACP cannot be created from any remaining menu.
Review preconditions
cursor/agent-session-composer-17c0on currentmain(workspace tabs already merged).pnpm test/pnpm checkshould be green (464 tests at last run).+menu has no TUI rows; new session can switch JuCode/Claude/Codex before the first message and cannot after; hover-effort selects model+effort; footer shows branch + context.Test results
pnpm test: 29 files, 464 tests passed.pnpm check: 0 errors.