Skip to content

build: refresh uv.lock to current aTrain_core develop (runnable install)#166

Merged
JuergenFleiss merged 1 commit into
JuergenFleiss:developfrom
BW-Projects:bugfixes_refresh_atrain_core_lock
May 27, 2026
Merged

build: refresh uv.lock to current aTrain_core develop (runnable install)#166
JuergenFleiss merged 1 commit into
JuergenFleiss:developfrom
BW-Projects:bugfixes_refresh_atrain_core_lock

Conversation

@BW-Projects
Copy link
Copy Markdown

develop currently can't be installed and run from a fresh clone:
uv sync produces an environment where import aTrain fails with
cannot import name 'FLATPAK' from 'aTrain_core.globals'.

Cause

The lockfile pinned aTrain_core at an old develop commit
(44e88478, pre-FLATPAK). uv keeps the cached git commit for the
@develop ref across uv lock runs unless --upgrade-package is
passed, so the pin had silently gone stale and predates the FLATPAK
global the app now imports.

Fix

Refresh the locked commit to the current develop HEAD (2f3d2c6),
which carries FLATPAK plus the recent aTrain_core fixes:

With #48 in place the resolver now selects matching
torch==2.9.1+cu128 / torchaudio==2.9.1+cu128 instead of the
previously mismatched torchaudio 2.11.0 (which failed at import
with undefined symbol: torch_library_impl).

Lock-only changepyproject.toml is untouched (still
@develop). This does not pre-empt the long-term pinning decision in
#145 (SHA-pin vs monorepo); it only refreshes the stale locked commit
so develop is installable again today.

Verification

  • uv sync --locked on a clean checkout succeeds.
  • python -m aTrain --help works; aTrain start
  • import torchaudio succeeds (matched ABI).

Related: #145, JuergenFleiss/atrain_core#46, JuergenFleiss/atrain_core#48

cc @gerardo-navarro

The lockfile pinned `aTrain_core` at an old develop commit
(`44e88478`, pre-FLATPAK) that predates the `FLATPAK` global the app
now imports. uv keeps a cached git commit for the `@develop` ref
across `uv lock` runs unless `--upgrade-package` is passed, so the
pin had silently gone stale: a fresh `uv sync` produced an
environment where `import aTrain` fails on the missing `FLATPAK`
symbol.

Refresh the locked commit to the current develop HEAD
(`2f3d2c6`), which carries the `FLATPAK` global plus the recent
aTrain_core fixes (outputs.py match-arity, JuergenFleiss/atrain_core#46;
torchaudio/torch ABI pin, JuergenFleiss/atrain_core#48). With JuergenFleiss#48 in
place the resolver now selects matching `torch==2.9.1+cu128` /
`torchaudio==2.9.1+cu128` instead of the previously mismatched
`torchaudio 2.11.0` (which failed at import with
`undefined symbol: torch_library_impl`).

Lock-only change; `pyproject.toml` is untouched (still `@develop`).
Verified: `uv sync --locked` on a clean checkout succeeds and the
app imports + CLI run.
@JuergenFleiss JuergenFleiss merged commit 6d69f8c into JuergenFleiss:develop May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants