Fix wrong makeunique suggestion in stack error message#3526
Merged
bkamins merged 1 commit intoJuliaData:mainfrom Mar 17, 2026
Merged
Fix wrong makeunique suggestion in stack error message#3526bkamins merged 1 commit intoJuliaData:mainfrom
bkamins merged 1 commit intoJuliaData:mainfrom
Conversation
This was referenced Feb 28, 2026
Contributor
Author
|
@bkamins Can you please review the PR? |
Member
|
Yes |
Member
|
@nalimilan - can you please have a look before merging. Thank you! |
nalimilan
approved these changes
Mar 16, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3487
Where, it changed the error message in
stackto suggestvariable_nameandvalue_namekeyword arguments instead ofmakeunique, which is not a valid argument forstack.Also added the same check to
_stackviewfor theview=truepath, and added tests for both paths