Use TaskLocalValues#2075
Draft
vchuravy wants to merge 2 commits into
Draft
Conversation
…ronment. Normally Pkg.test does this for us, but here we're launching runbenchmarks.jl directly. [skip tests]
maleadt
force-pushed
the
master
branch
15 times, most recently
from
5d585c4 to
c850163
Compare
maleadt
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 71.58% 0.23% -71.35%
==========================================
Files 157 150 -7
Lines 13803 13068 -735
==========================================
- Hits 9881 31 -9850
- Misses 3922 13037 +9115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment to see if the API for TaskLocalValues fullfills our needs here.
I already see a whole were CUDA does querying if the value is set or not.
Unsure if we want a
isinitializedfunction or anget(::TaskLocalValue, nothing) == nothing