Restore CPU-RNG to GPU-array fallback for rand!/randn!.#710
Merged
Conversation
Without this, e.g. `randn!(Random.TaskLocalRNG(), ::CuArray)` falls through to the stdlib scalar setindex! path. Regression from #707.
kshyatt
approved these changes
Apr 16, 2026
Member
kshyatt
left a comment
kshyatt
left a comment
There was a problem hiding this comment.
Yikes that we gotta copy but I guess that's really the only solution here
Member
Author
|
It's probably even better for your GPU array-containing struct to provide a |
Member
|
Yep, that's on the menu for TensorKit as we upgrade its deps to version 6 of everything :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, e.g.
randn!(Random.TaskLocalRNG(), ::CuArray)falls through to the stdlib scalar setindex! path. Regression from #707.