Generalize norm and normalize to AnyGPUArray.#720
Merged
Merged
Conversation
Lets `norm`/`normalize` short-circuit the LinearAlgebra dispatch for SubArrays/wrappers of GPU arrays, which would otherwise fall back to `norm_recursive_check` (Julia 1.12+) or `generic_norm2`, both of which iterate and trigger scalar indexing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Does this also cover |
Member
Author
|
No, that's not covered by Adapt's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets
norm/normalizeshort-circuit the LinearAlgebra dispatch for SubArrays/wrappers of GPU arrays, which would otherwise fall back tonorm_recursive_check(Julia 1.12+) orgeneric_norm2, both of which iterate and trigger scalar indexing.