Skip to content

Metal: Configure TTI so that InferAddressSpaces works.#782

Merged
maleadt merged 4 commits into
masterfrom
tb/metal_as_tti
Apr 23, 2026
Merged

Metal: Configure TTI so that InferAddressSpaces works.#782
maleadt merged 4 commits into
masterfrom
tb/metal_as_tti

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented Apr 22, 2026

Fixes #781

Copy link
Copy Markdown

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I can't speak to the contents of src/metal.jl, but test/metal.jl does seem to test the issue I faced. Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.45%. Comparing base (3084db6) to head (110fd56).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/metal.jl 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   75.42%   75.45%   +0.03%     
==========================================
  Files          24       24              
  Lines        3857     3879      +22     
==========================================
+ Hits         2909     2927      +18     
- Misses        948      952       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt merged commit 8f434a7 into master Apr 23, 2026
37 checks passed
@maleadt maleadt deleted the tb/metal_as_tti branch April 23, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metal kernel reads zeros from constant globals with dynamic indexing

2 participants